If a function has a guint "out argument", passing a pointer to a gsize
is not, in general, valid. On an ILP64 platform there is no problem
since guint and gsize are identical, but on an LP64 platform it will
overwrite only the first word of the gsize, leaving the second word
unaffected. On little-endian machines, if the second word is
zero-initialized (as it is here), the result is numerically equal to
the guint, but on big-endian machines the result is around 4 billion
times what it should be, resulting in
ostree_repo_finder_config_resolve_async() reading past the end of
the array and causing undefined behaviour.
In practice this caused assertion failures (and consequently test
failures) on Debian's s390x (z/Architecture), ppc64 (64-bit PowerPC)
and sparc64 (64-bit SPARC) ports.
Closes: #1640
Signed-off-by: Simon McVittie <smcv@debian.org>
Closes: #1641
Approved by: cgwalters
We special-case AVAHI_ERR_NO_DAEMON to not cause warnings, but if
we pass AVAHI_CLIENT_NO_FAIL to avahi_client_new, we never actually
see AVAHI_ERR_NO_DAEMON. Instead, we will get AVAHI_ERR_BAD_STATE
when we try to use the client.
Closes: #1618
Signed-off-by: Simon McVittie <smcv@debian.org>
Closes: #1639
Approved by: cgwalters
* New upstream git snapshot with support for peer-to-peer software
collections, required by Flatpak's peer-to-peer app sharing feature
- d/copyright: Update
- d/libostree-1-1.symbols: Update
- Build-depend on Avahi libraries
- d/ostree-boot.install: Add new systemd service
lib/systemd/system/ostree-finalize-staged.service
- d/rules: Remove lib/systemd/system/ostree-finalize-staged.service
until we build ostree-boot
- d/copyright: Upstream clarified that only doc/ is CC-BY-SA-3.0 or
GFDL-1.3-or-later, and doc/ isn't included in dist tarballs, so
remove those licenses
- d/libostree-1-1.symbols: Update (and sort)
* Update symbols file
* Drop all patches, including one that was previously considered to
be Debian-specific (moving to Python 3 for tests)
* d/copyright: Update
* d/p/{debian/,}Use-Python-3-for-tests.patch:
Mark patch as forwarded. It was previously considered
Debian-specific, but upstream seem interested.
* Mark all other patches as applied upstream for 2018.3
This is a little clearer than a strcmp()-style negative/zero/positive
return, and also works in Python 2.
Signed-off-by: Simon McVittie <smcv@debian.org>
Closes: #1457
Approved by: cgwalters
Python 3 is pickier about this. Python 2.7 has Python 3-compatible
semantics for division when the division feature is imported from the
future.
Signed-off-by: Simon McVittie <smcv@debian.org>
Closes: #1457
Approved by: cgwalters
range in Python 3 does what xrange did in Python 2. This still works in
Python 2, it just uses a bit more memory.
Signed-off-by: Simon McVittie <smcv@debian.org>
Closes: #1457
Approved by: cgwalters
gjs is not currently installable on buildds due to the glibc transition
and a long dependency chain involving systemd-shim being preferred over
systemd-sysv, which ends with libnih1 Depends: libc6 (<< 2.26).
* d/p/2017.13/lib-core-Init-struct-stat-buffer.patch,
d/p/2017.13/lib-sysroot-Fix-pointer-going-out-of-scope-in-unlock-code.patch,
d/p/2017.13/lib-deploy-Ignore-FIFREEZE-FITHAW-errors-when-already-in-.patch,
d/p/2017.13/lib-deploy-Use-_exit-for-FIFREEZE-watchdog.patch,
d/p/2017.13/lib-deltas-Check-cancellable-during-processing.patch,
d/p/2017.13/lib-utils-Check-for-invalid-UTF-8-in-filenames.patch,
d/p/2017.13/Cope-with-xattr-syscalls-raising-EOPNOTSUPP.patch,
d/p/2017.13/lib-sysroot-Fix-error-handling-when-mounting-overlayfs-fa.patch,
d/p/2017.13/lib-repo-Properly-handle-NULL-homedir-when-signing-commit.patch,
d/p/2017.13/lib-repo-Fix-loading-commitstate-with-parent-repos.patch:
Add various bugfix patches from upstream
* d/p/2017.13/tests-Add-test-pull-bareuseronly.patch:
Add more test coverage from upstream
In particular this affects architecture-specific builds. Note that it
remains in Build-Depends (not Build-Depends-Indep) because it is also
needed for gtkdocize during dh_autoreconf.
Simon McVittie