Colin Walters
3d38f03e4f
The gzip default is 6. When I was writing this code, I chose 9 under the assumption that for long-term archival, the extra compression was worth it. Turns out level 9 is really, really not worth it. Here's run at level 9 compressing the current Fedora Atomic Host into archive: ``` ostree --repo=repo pull-local repo-build fedora-atomic/25/x86_64/docker-host real 2m38.115s user 2m31.210s sys 0m3.114s 617M repo ``` And here's the new default level of 6: ``` ostree --repo=repo pull-local repo-build fedora-atomic/25/x86_64/docker-host real 0m53.712s user 0m43.727s sys 0m3.601s 619M repo 619M total ``` As you can see, we run almost *three times* faster, and we take up *less than one percent* more space. Conclusion: Using level 9 is dumb. And here's a run at compression level 1: ``` ostree --repo=repo pull-local repo-build fedora-atomic/25/x86_64/docker-host real 0m24.073s user 0m17.574s sys 0m2.636s 643M repo 643M total ``` I would argue actually many people would prefer even this for "devel" repos. For production repos, you want static deltas anyways. (However, perhaps we should support a model where generating a delta involves re-compressing fallback objects with a bit stronger compression level). Anyways, let's make everyone's life better and switch the default to 6. Closes: #671 Approved by: jlebon
162 lines
5.4 KiB
C
162 lines
5.4 KiB
C
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*-
|
|
*
|
|
* Copyright (C) 2013 Colin Walters <walters@verbum.org>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 02111-1307, USA.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "ostree-core.h"
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
/* It's what gzip does, 9 is too slow */
|
|
#define OSTREE_ARCHIVE_DEFAULT_COMPRESSION_LEVEL (6)
|
|
|
|
/* This file contains private implementation data format definitions
|
|
* read by multiple implementation .c files.
|
|
*/
|
|
|
|
/*
|
|
* File objects are stored as a stream, with one #GVariant header,
|
|
* followed by content.
|
|
*
|
|
* The file header is of the following form:
|
|
*
|
|
* <BE guint32 containing variant length>
|
|
* u - uid
|
|
* u - gid
|
|
* u - mode
|
|
* u - rdev (must be 0)
|
|
* s - symlink target
|
|
* a(ayay) - xattrs
|
|
*
|
|
* Then the rest of the stream is data.
|
|
*/
|
|
#define _OSTREE_FILE_HEADER_GVARIANT_FORMAT G_VARIANT_TYPE ("(uuuusa(ayay))")
|
|
|
|
/*
|
|
* A variation on %OSTREE_FILE_HEADER_GVARIANT_FORMAT, used for
|
|
* storing zlib-compressed content objects.
|
|
*
|
|
* <BE guint32 containing variant length>
|
|
* t - size
|
|
* u - uid
|
|
* u - gid
|
|
* u - mode
|
|
* u - rdev (must be 0)
|
|
* s - symlink target
|
|
* a(ayay) - xattrs
|
|
* ---
|
|
* zlib-compressed data
|
|
*/
|
|
#define _OSTREE_ZLIB_FILE_HEADER_GVARIANT_FORMAT G_VARIANT_TYPE ("(tuuuusa(ayay))")
|
|
|
|
|
|
GVariant *_ostree_file_header_new (GFileInfo *file_info,
|
|
GVariant *xattrs);
|
|
|
|
GVariant *_ostree_zlib_file_header_new (GFileInfo *file_info,
|
|
GVariant *xattrs);
|
|
|
|
gboolean _ostree_write_variant_with_size (GOutputStream *output,
|
|
GVariant *variant,
|
|
guint64 alignment_offset,
|
|
gsize *out_bytes_written,
|
|
GChecksum *checksum,
|
|
GCancellable *cancellable,
|
|
GError **error);
|
|
|
|
gboolean
|
|
_ostree_make_temporary_symlink_at (int tmp_dirfd,
|
|
const char *target,
|
|
char **out_name,
|
|
GCancellable *cancellable,
|
|
GError **error);
|
|
|
|
GFileInfo * _ostree_header_gfile_info_new (mode_t mode, uid_t uid, gid_t gid);
|
|
|
|
/* XX/checksum-2.extension, but let's just use 256 for a
|
|
* bit of overkill.
|
|
*/
|
|
#define _OSTREE_LOOSE_PATH_MAX (256)
|
|
|
|
char *
|
|
_ostree_get_relative_object_path (const char *checksum,
|
|
OstreeObjectType type,
|
|
gboolean compressed);
|
|
|
|
|
|
char *
|
|
_ostree_get_relative_static_delta_path (const char *from,
|
|
const char *to,
|
|
const char *target);
|
|
|
|
char *
|
|
_ostree_get_relative_static_delta_superblock_path (const char *from,
|
|
const char *to);
|
|
|
|
char *
|
|
_ostree_get_relative_static_delta_detachedmeta_path (const char *from,
|
|
const char *to);
|
|
|
|
char *
|
|
_ostree_get_relative_static_delta_part_path (const char *from,
|
|
const char *to,
|
|
guint i);
|
|
|
|
static inline char * _ostree_get_commitpartial_path (const char *checksum)
|
|
{
|
|
return g_strconcat ("state/", checksum, ".commitpartial", NULL);
|
|
}
|
|
|
|
gboolean
|
|
_ostree_parse_delta_name (const char *delta_name,
|
|
char **out_from,
|
|
char **out_to,
|
|
GError **error);
|
|
|
|
void
|
|
_ostree_loose_path (char *buf,
|
|
const char *checksum,
|
|
OstreeObjectType objtype,
|
|
OstreeRepoMode repo_mode);
|
|
|
|
#define _OSTREE_METADATA_GPGSIGS_NAME "ostree.gpgsigs"
|
|
#define _OSTREE_METADATA_GPGSIGS_TYPE G_VARIANT_TYPE ("aay")
|
|
|
|
GVariant *
|
|
_ostree_detached_metadata_append_gpg_sig (GVariant *existing_metadata,
|
|
GBytes *signature_bytes);
|
|
|
|
GFile *
|
|
_ostree_get_default_sysroot_path (void);
|
|
|
|
_OSTREE_PUBLIC
|
|
gboolean
|
|
_ostree_raw_file_to_archive_stream (GInputStream *input,
|
|
GFileInfo *file_info,
|
|
GVariant *xattrs,
|
|
guint compression_level,
|
|
GInputStream **out_input,
|
|
GCancellable *cancellable,
|
|
GError **error);
|
|
|
|
|
|
|
|
G_END_DECLS
|